Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up provisioning of the first set of worker machines by improving predicates on cluster watch #8835

Open
fabriziopandini opened this issue Jun 12, 2023 · 3 comments
Labels
area/bootstrap Issues or PRs related to bootstrap providers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Jun 12, 2023

What would you like to be added (User Story)?

As a users I want CAPI to provision machines as fast as possible

Detailed Description

While looking at cluster provisioning I noticed that the kubeadm bootstrap controller takes time to react to when the cluster reports control plane ready, which is the moment when workers machines are allowed to join.

From a preliminary investigation, the kubeadm bootstrap controller is watching for clusters, but existing predicates (more specifically predicates.ClusterUnpausedAndInfrastructureReady) are filtering out events when the cluster transition to control plane ready.

This issue is about investigating if we can speed up provisioning of the first set of worker machines by improving predicates

Anything else you would like to add?

Note predicates.ClusterUnpausedAndInfrastructureReady, so some research is required before changing this method, or most probably it is better to create a new one.

Label(s) to be applied

/kind feature
/area bootstrap

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/bootstrap Issues or PRs related to bootstrap providers needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2023
@sbueringer
Copy link
Member

Sounds reasonable and low risk to let a few more events through

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 13, 2023
@sbueringer sbueringer mentioned this issue Jun 13, 2023
27 tasks
@fabriziopandini
Copy link
Member Author

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 11, 2024
@fabriziopandini fabriziopandini added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 6, 2024
@fabriziopandini
Copy link
Member Author

For someone to re-assess after all the optimizations in 1.5
/help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Issues or PRs related to bootstrap providers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants