Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failureDomain as a required field in the machine controller docs #7301

Closed
Jont828 opened this issue Sep 28, 2022 · 6 comments
Closed

Add failureDomain as a required field in the machine controller docs #7301

Jont828 opened this issue Sep 28, 2022 · 6 comments
Assignees
@Jont828
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Jont828
Copy link
Contributor

Jont828 commented Sep 28, 2022

/kind bug

The infra machine provider contract lists failureDomain as a required contract field. It's not listed in the machine controller section however, and it should be added in order to be consistent.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 28, 2022
@sbueringer
Copy link
Member

Some nits:
failureDomain is an optional spec field (not required).
Would be also good to add the optional status field addresses.

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 28, 2022
@sbueringer sbueringer added kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 28, 2022
@fabriziopandini
Copy link
Member

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Sep 28, 2022
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 28, 2022
@Jont828
Copy link
Contributor Author

Jont828 commented Sep 29, 2022

/assign

@Jont828 Jont828 mentioned this issue Sep 30, 2022
Merged
@Jont828
Copy link
Contributor Author

Jont828 commented Nov 17, 2022

Should be fixed in #7328, looks like this didn't get closed when that merged.

@Jont828 Jont828 closed this as completed Nov 17, 2022
@sbueringer
Copy link
Member

Yup looks like Fixes only works with one issue per line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jont828 Jont828

Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbueringer @fabriziopandini @Jont828 @k8s-ci-robot