Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding CAPD infrastructure components manifest #6972

Closed
abhay-krishna opened this issue Jul 22, 2022 · 4 comments · Fixed by #6973
Closed

Question regarding CAPD infrastructure components manifest #6972

abhay-krishna opened this issue Jul 22, 2022 · 4 comments · Fixed by #6973
Assignees

Comments

@abhay-krishna
Copy link
Contributor

I downloaded the CAPD manifest linked in the v1.2.0 release and noticed that the image referenced in the Deployment was tagged main.

$ curl -fsSL https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.2.0/infrastructure-components-development.yaml | grep image:
        image: gcr.io/k8s-staging-cluster-api/capd-manager:main

For previous releases however it is tagged with that tag version

$ curl -fsSL https://github.com/kubernetes-sigs/cluster-api/releases/download/v1.1.5/infrastructure-components-development.yaml | grep image:
        image: gcr.io/k8s-staging-cluster-api/capd-manager:v1.1.5

I was wondering if this is intended for every new version that comes out, where the latest CAPD image deployed will be tagged main.

@abhay-krishna
Copy link
Contributor Author

/area provider/docker

@killianmuldoon
Copy link
Contributor

/assign

Definitely seems like an issue with the latest release.

@killianmuldoon
Copy link
Contributor

killianmuldoon commented Jul 25, 2022

@abhay-krishna Thanks for catching this! The image is published and available so you should change the image in your local manifest to gcr.io/k8s-staging-cluster-api/capd-manager:v1.2.0. I'm going to figure out our options for updating the release with the fixed manifest.

@killianmuldoon
Copy link
Contributor

This should be fixed in the current release branch, and I've got a PR out to fix the root cause in how our manifests are being generated. Thanks again for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants