Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend external patch implementation in RuntimeSDK e2e test #6859

Closed
sbueringer opened this issue Jul 7, 2022 · 2 comments · Fixed by #6918
Closed

Extend external patch implementation in RuntimeSDK e2e test #6859

sbueringer opened this issue Jul 7, 2022 · 2 comments · Fixed by #6918
Assignees
Labels
area/runtime-sdk Issues or PRs related to Runtime SDK kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@sbueringer
Copy link
Member

sbueringer commented Jul 7, 2022

Our RuntimeSDK e2e test tests external patching by calling a test extension.

Initially we only moved one patch from the ClusterClass to the test extension

Goal of this issue is to move all inline patches of the RuntimeSDk ClusterClass to the test extension handler, to increase test coverage and get some experience on how to implement external patches.

Note:

  • Let's also implement some validations in the ValidateTopology extension handler

Links:

@sbueringer sbueringer added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/runtime-sdk Issues or PRs related to Runtime SDK labels Jul 7, 2022
@killianmuldoon
Copy link
Contributor

/assign

I'll get working on this

@fabriziopandini fabriziopandini added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jul 29, 2022
@fabriziopandini fabriziopandini added this to the v1.3 milestone Aug 5, 2022
@fabriziopandini
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime-sdk Issues or PRs related to Runtime SDK kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants