Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeadmControlPlane spec.kubeadmConfigSpec.joinConfiguration.patches.directory should be mutable #6576

Closed
superbrothers opened this issue May 31, 2022 · 3 comments · Fixed by #6586
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.

Comments

@superbrothers
Copy link
Contributor

User Story

As an operator I would like to be able to modify KubeadmControlPlane spec.kubeadmConfigSpec.joinConfiguration.patches.directory.

Detailed Description

I want to update the spec of apiserver of the existing cluster, but changes to this field are not permitted currently.

The KubeadmControlPlane "eval-control-plane" is invalid:
* spec.kubeadmConfigSpec.initConfiguration.patches.directory: Forbidden: cannot be modified
* spec.kubeadmConfigSpec.joinConfiguration.patches.directory: Forbidden: cannot be modified

Anything else you would like to add:

None

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2022
@sbueringer
Copy link
Member

@superbrothers Sounds good to me.

To implement this we have to:

@sbueringer sbueringer added the area/control-plane Issues or PRs related to control-plane lifecycle management label May 31, 2022
@superbrothers
Copy link
Contributor Author

@sbueringer Thanks for your quick comment. I'll implement it.

@superbrothers
Copy link
Contributor Author

@sbueringer I've created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants