Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterClass: control plane template rotation leaks InfrastructureMachineTemplates #6375

Closed
sbueringer opened this issue Apr 4, 2022 · 1 comment · Fixed by #6399
Closed
Assignees
Labels
area/clusterclass Issues or PRs related to clusterclass kind/bug Categorizes issue or PR as related to a bug.

Comments

@sbueringer
Copy link
Member

sbueringer commented Apr 4, 2022

What steps did you take and what happened:

With ClusterClass, when a control plane InfrastructureMachineTemplate is rotated we don't delete the old template.

What did you expect to happen:
I expect old templates to be deleted - at least on a best effort basis.

Anything else you would like to add:

This can be reproduced by deploying a CAPD cluster with ClusterClass. After the initial deployment
the InfrastructureMachineTemplate of KCP must be modified to trigger rotations. This can be e.g. done
by changing the template referenced in the ClusterClass or changing fields via patches.

Environment:

  • Cluster-api version: latest
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
/area topology
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

/cc @fabriziopandini

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/topology labels Apr 4, 2022
@sbueringer sbueringer changed the title ClusterClass: InfrastructureMachineTemplates are leaked on template rotation ClusterClass: template rotation leaks InfrastructureMachineTemplates Apr 4, 2022
@sbueringer sbueringer changed the title ClusterClass: template rotation leaks InfrastructureMachineTemplates ClusterClass: control plane template rotation leaks InfrastructureMachineTemplates Apr 4, 2022
@killianmuldoon
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterclass Issues or PRs related to clusterclass kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
3 participants