-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace github.com/gosuri/uitable
with github.com/olekukonko/tablewriter
#5941
Comments
I would like to try |
@ykakarap have got everything almost ready however there is an issue in the testing part cluster-api/cmd/clusterctl/cmd/describe_cluster_test.go Lines 280 to 287 in 58f834f
How to access specific rows and column in tablewriter like uitable , there does not seem to be method to implement line 287. The tests can be modified to be like these here https://github.com/olekukonko/tablewriter/blob/master/table_test.go |
@DiptoChakrabarty Firstly, thank you for stepping up to work on this. 👍🏼 |
/remove-kind feature |
/kind cleanup |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Detailed Description
github.com/olekukonko/tablewriter
is introduced in the #5893 . This new library is more feature rich and can be used to do everything thatgithub.com/gosuri/uitable
. Therefore, it would be good to replace the later with the former so that we dont have to include two table libraries.Anything else you would like to add:
github.com/gosuri/uitable
is currently being used by theclusterctl describe cluster
command.[Miscellaneous information that will assist in solving the issue.]
/kind feature
/area clusterctl
The text was updated successfully, but these errors were encountered: