Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move controllers/topology/internal/check to /internal/topology/check #5614

Closed
killianmuldoon opened this issue Nov 9, 2021 · 1 comment · Fixed by #5616
Closed

Move controllers/topology/internal/check to /internal/topology/check #5614

killianmuldoon opened this issue Nov 9, 2021 · 1 comment · Fixed by #5616
Labels
area/clusterclass Issues or PRs related to clusterclass kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@killianmuldoon
Copy link
Contributor

The folder at controllers/topology/internal/check is currently used for validation of clusterClass and managedTopology related operations.

A number of similar operations are now being added in the new top level webhooks folder in order to assess compatibility between clusterclasses.

These functions should be moved to the top-level internal package to make them available across the CAPI codebase, including the webhook validation checks.
@killianmuldoon
Copy link
Contributor Author

/area topology
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/topology kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 9, 2021
@killianmuldoon killianmuldoon mentioned this issue Nov 9, 2021
Merged
@killianmuldoon killianmuldoon added the area/clusterclass Issues or PRs related to clusterclass label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/clusterclass Issues or PRs related to clusterclass kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Move topology/internal/checks to top level internal package killianmuldoon/cluster-api
2 participants
@k8s-ci-robot @killianmuldoon