Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Controller Runtime v0.11.x #5576

Closed
1 task done
sbueringer opened this issue Nov 3, 2021 · 2 comments · Fixed by #5866
Closed
1 task done

Upgrade to Controller Runtime v0.11.x #5576

sbueringer opened this issue Nov 3, 2021 · 2 comments · Fixed by #5866
Labels
area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Milestone

Comments

@sbueringer
Copy link
Member

sbueringer commented Nov 3, 2021

It would be great if we can use the next controller-runtime release (v0.11.x) in one of our next CAPI releases.

Anything else you would like to add:

I know it's early to already open the issue, but I think it's good to already have it so we're able to collect post-CR-upgrade tasks and also discuss if we want to already upgrade in CAPI v1.1.

Notes:

  • as of today there is no CR v0.11 release
  • CR main currently uses
    • Kubernetes 1.23.x (also doesn't have a release yet)
    • go-logr/logr v1.x (and thus enables kubernetes/klog v2.20+)

Post CR-upgrade tasks:

  • Let's reconsider if we want to set the call depth when constructing the topologyReconcileLogger instead of during logging as introduced in 🌱 topologyReconcileLogger: print the correct log lines #5568
    • Note: With the new go-logr version that code won't compile anymore, so we have to do something when upgrading CR anyway.

First feedback in Slack suggests that we "probably want to use CR v0.11 in CAPI v1.1" and that it "probably makes sense to wait for a CR RC".

[Miscellaneous information that will assist in solving the issue.]

/kind feature
/area dependency

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes labels Nov 3, 2021
@vincepri
Copy link
Member

vincepri commented Nov 3, 2021

/milestone v1.1
/kind release-blocking

@sbueringer
Copy link
Member Author

Note: we're now on a pre-release version (a commit from main after beta 0) of CR. Let's keep this issue open until we use a v0.11.x CR release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants