Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration flag for Machine Deletion Timeouts #5516

Closed
chatla-telekom opened this issue Oct 27, 2021 · 6 comments · Fixed by #5608
Closed

Add a configuration flag for Machine Deletion Timeouts #5516

chatla-telekom opened this issue Oct 27, 2021 · 6 comments · Fixed by #5608
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@chatla-telekom
Copy link

User Story

As a user I would like to have the possibility for specifying the timeout duration for machine deletion.

Detailed Description

According to the current implementation, the timeout for machine deletion is set to 10 seconds after which the machine is not deleted. This is not feasible in some cases as it leads to orphan machines in the clusters even after they are deleted in the control plane. By having the possibility to configure the machine deletion timeout, CAPI can retry to delete the machine until the timeout set by the user.

If the flag is not set, the timeout would fall back to the default value of 10 seconds.

More about this can be found in this discussion on Slack: https://kubernetes.slack.com/archives/C8TSNPY4T/p1631180381209300

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 27, 2021
@chatla-telekom
Copy link
Author

@MaxRink @schrej

@schrej
Copy link
Member

schrej commented Oct 27, 2021

I've already started working on a PR for this, it's just missing tests, which are somewhat tricky to implement.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2022
@sbueringer
Copy link
Member

/remove-lifecycle stale
PR in progress

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2022
@sbueringer
Copy link
Member

/lifecycle active
/assign @schrej

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jan 26, 2022
@fabriziopandini
Copy link
Member

/milestone v1.2

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants