Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology reconciler fails to patch ClusterClass #5342

Closed
fabriziopandini opened this issue Sep 28, 2021 · 2 comments · Fixed by #5343
Closed

Topology reconciler fails to patch ClusterClass #5342

fabriziopandini opened this issue Sep 28, 2021 · 2 comments · Fixed by #5343
Assignees
@fabriziopandini
Labels
area/clusterclass Issues or PRs related to clusterclass kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Milestone
v1.0

Comments

@fabriziopandini
Copy link
Member

Topology reconciler needs to patch a ClusterClass in case references GVK has to be updated to match current ClusterAPI contract, but it fails due to lack of RBAC permission

E0928 14:16:47.120325       9 controller.go:317] controller/topology/cluster "msg"="Reconciler error" "error"="error reading the ClusterClass: failed to patch ClusterClass/clusterclass1: clusterclasses.cluster.x-k8s.io \"clusterclass1\" is forbidden: User \"system:serviceaccount:capi-system:capi-manager\" cannot patch resource \"clusterclasses\" in API group \"cluster.x-k8s.io\" in the namespace \"default\"" "name"="my-cluster1" "namespace"="default" "reconciler group"="cluster.x-k8s.io" "reconciler kind"="Cluster"

Environment:

  • Cluster-api version: main

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 28, 2021
@fabriziopandini
Copy link
Member Author

/area topology
/milestone v1.0
/kind release-blocking

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Sep 28, 2021
@k8s-ci-robot k8s-ci-robot added area/topology kind/release-blocking Issues or PRs that need to be closed before the next CAPI release labels Sep 28, 2021
@fabriziopandini
Copy link
Member Author

/assign

@fabriziopandini fabriziopandini mentioned this issue Sep 28, 2021
Merged
@killianmuldoon killianmuldoon added the area/clusterclass Issues or PRs related to clusterclass label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziopandini fabriziopandini

Labels
area/clusterclass Issues or PRs related to clusterclass kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

🐛 Add permission for changing ClusterClass to topology controller fabriziopandini/cluster-api
3 participants
@fabriziopandini @k8s-ci-robot @killianmuldoon