Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterClass rebase #5318

Closed
fabriziopandini opened this issue Sep 24, 2021 · 6 comments · Fixed by #5644
Closed

ClusterClass rebase #5318

fabriziopandini opened this issue Sep 24, 2021 · 6 comments · Fixed by #5644
Assignees
Labels
area/clusterclass Issues or PRs related to clusterclass kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@fabriziopandini
Copy link
Member

User Story

As a user/operator I would like to change a ClusterClass for a specific Cluster

Detailed Description
Many Cluster could share the same ClusterClass; whenever I change a ClusterClass, all the Cluster align to changes.
This is powerful, but in some cases I would like to have an alternative to change Clusters in a more controller way.

A possible solution to address this issue is to allow changing the ClusterClass for an existing Cluster.

Please note that technically the current implementation of the topology controller already supports this operation, but this is currently blocked by Cluster webhook.

In order to make this possible:

  • The cluster webhook should be relaxed allowing this operation; also additional checks should be implemented in order to block if we detect that this operation violates compatibility rules.
  • Proper test coverage for this use case should be provided

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2021
@fabriziopandini
Copy link
Member Author

/area topology
/milestone v1.0

@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Sep 24, 2021
@ykakarap
Copy link
Contributor

/assign

@vincepri vincepri modified the milestones: v1.0, v1.1 Oct 22, 2021
@killianmuldoon
Copy link
Contributor

@ykakarap I think I'm going to be working on this - indirectly as part of #5537 . Have you made any progress yet?

@ykakarap
Copy link
Contributor

@killianmuldoon Please go ahead 👍🏼 :)
I dont think I will be able to get to this in the next few days anyway.

@killianmuldoon
Copy link
Contributor

/assign

@ykakarap
Copy link
Contributor

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterclass Issues or PRs related to clusterclass kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants