Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional validation checks for ClusterClass and managed topologies #4940

Closed
fabriziopandini opened this issue Jul 14, 2021 · 5 comments · Fixed by #4992
Closed

Additional validation checks for ClusterClass and managed topologies #4940

fabriziopandini opened this issue Jul 14, 2021 · 5 comments · Fixed by #4992
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@fabriziopandini
Copy link
Member

Detailed Description
This is a follow up of #4928 (comment)

The ClusterClass and managed topologies proposal introduced an initial set of web hook validation rules.
This issue is about adding more validation rules in order to make things even more robust, e.g.

  • Ensure all Ref are valid (*)
    • Ref can only reference template objects (Kind ends with Template suffix)
    • namespace if set should be a valid namespace name
    • apiVersion must be set and be a valid
    • kind must be set and be a valid
    • name must be set and be a valid (extends the first rule in this sublist)
  • Ensure all the required Ref exists in a ClusterClass
  • TDB ensure the user can't change a Cluster from unmanned to managed
  • ...

(*) Ideally this should be consistent with all the other references existing in the API types

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 14, 2021
@sbueringer
Copy link
Member

Sounds like a good issue to parallelize after #4928 has been merged.

@ykakarap
Copy link
Contributor

I can work on this :)
/assign

@vincepri
Copy link
Member

/milestone v0.4

@sbueringer
Copy link
Member

@ykakarap Can you please also extend the KubeadmControlPlane webhook to also validate the name of the infrastructure machineTemplate ObjectReference

More details in: #4986 (comment)

@ykakarap
Copy link
Contributor

@sbueringer will do 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants