Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Machines created by CAPD should use Kind's default network #3832

Closed
tcordeu opened this issue Oct 20, 2020 · 6 comments · Fixed by #4002
Closed

Machines created by CAPD should use Kind's default network #3832

tcordeu opened this issue Oct 20, 2020 · 6 comments · Fixed by #4002
Assignees
@tcordeu
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4

Comments

@tcordeu
Copy link
Contributor

tcordeu commented Oct 20, 2020

User Story

As a developer I would like to change the network for machines created by CAPD to simplify the development workflow.

Detailed Description

Currently, machines created by CAPD use the bridge network and, as of v0.8.0, Kind uses the kind network. We should change the network to match Kind, this will remove the need to set KIND_EXPERIMENTAL_DOCKER_NETWORK to bridge when running local clusters or E2E tests.

Anything else you would like to add:

See #3815 (comment).

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 20, 2020
@tcordeu tcordeu mentioned this issue Oct 20, 2020
Merged
@tcordeu
Copy link
Contributor Author

tcordeu commented Oct 22, 2020

@fabriziopandini would you mind assigning me this issue?

@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 22, 2020
@tcordeu
Copy link
Contributor Author

tcordeu commented Oct 22, 2020

/assign @tcordeu

@fabriziopandini
Copy link
Member

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 22, 2020
@vincepri
Copy link
Member

vincepri commented Nov 2, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 2, 2020
@fabriziopandini
Copy link
Member

/area testing
/area provider/docker

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing area/provider/docker labels Nov 12, 2020
@fabriziopandini fabriziopandini mentioned this issue Nov 15, 2020
Closed
@tcordeu tcordeu mentioned this issue Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcordeu tcordeu

Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

⚠️ Use Kind's default network in CAPD tcordeu/cluster-api
4 participants
@vincepri @fabriziopandini @k8s-ci-robot @tcordeu