Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting the condition counter in the Ready Conditions #3739

Closed
fabriziopandini opened this issue Oct 5, 2020 · 1 comment · Fixed by #3740
Closed

Error reporting the condition counter in the Ready Conditions #3739

fabriziopandini opened this issue Oct 5, 2020 · 1 comment · Fixed by #3740
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@fabriziopandini
Copy link
Member

What steps did you take and what happened:
As of today, we use two options to set up a condition counter for the ready conditions, WithConditions and WithStepCounterIfOnly, e.g.

conditions.SetSummary(machine,
    conditions.WithConditions(
        clusterv1.InfrastructureReadyCondition,
        clusterv1.BootstrapReadyCondition,
    ),
    conditions.WithStepCounterIf(machine.ObjectMeta.DeletionTimestamp.IsZero()),
    conditions.WithStepCounterIfOnly(
        clusterv1.BootstrapReadyCondition,
        clusterv1.InfrastructureReadyCondition,
    ),
)

When the list of conditions in WithConditions and WithStepCounterIfOnly does not have the same order, like in the example above, SetSummary fails to report the summary (the summary 0 of 2 completed does not appear)

What did you expect to happen:
The condition counter to be properly created

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 5, 2020
@fabriziopandini
Copy link
Member Author

/milestone v0.3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants