Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRS] Watch ConfigMap/Secret creation/update for retrying to apply failed ones #3397

Closed
sedefsavas opened this issue Jul 24, 2020 · 2 comments · Fixed by #3410
Closed

[CRS] Watch ConfigMap/Secret creation/update for retrying to apply failed ones #3397

sedefsavas opened this issue Jul 24, 2020 · 2 comments · Fixed by #3410
Assignees
Milestone

Comments

@sedefsavas
Copy link

In the current ClusterResourceSet implementation, in case resources do not exist during reconcile, we wait until next reconcile to try to find and apply them again, which is set to 10 minutes for all controllers in CAPI.
For better user experience, we can watch resource changes and try to reapply failed ones if anything changes on the resource (created/updated).

Note that there is only ApplyOnce strategy exist in CRS as of now so we will not try to reapply resources when change is detected if they are already successfully applied before.

@sedefsavas
Copy link
Author

/assign

cc @andrewsykim

@vincepri
Copy link
Member

/milestone v0.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants