Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for using external etcd cluster are incomplete #2941

Closed
scottslowe opened this issue Apr 20, 2020 · 7 comments · Fixed by #2962
Closed

Instructions for using external etcd cluster are incomplete #2941

scottslowe opened this issue Apr 20, 2020 · 7 comments · Fixed by #2962
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@scottslowe
Copy link
Contributor

What steps did you take and what happened:

I followed the instructions found at https://github.com/kubernetes-sigs/cluster-api/blob/master/bootstrap/kubeadm/docs/external-etcd.md and noted several errors in the document:

  1. One of the kubectl create secret commands references the etcd server certificate and key, but it should reference the etcd CA.
  2. The kubectl create secret tls command requires both certificate and key, but one of the commands references only the certificate.
  3. The instructions don't indicate that users will need to manually update security groups when using this procedure on AWS. (I would imagine that similar steps will be necessary for Azure, GCP, etc., although I haven't tested this process on those platforms yet.)

What did you expect to happen:

I expected the instructions to provide correct information on how to use an external etcd cluster with Cluster API.

Anything else you would like to add:

I have only tested this process using CAPA (so far).

Environment:

  • Cluster-api version: 0.3.3
  • Minikube/KIND version: N/A (tested on AWS)
  • Kubernetes version: (use kubectl version): v1.16.4 (management cluster), v1.17.3 (workload cluster)
  • OS (e.g. from /etc/os-release): Ubuntu 18.04

/kind bug

@fabriziopandini
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 21, 2020
@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Apr 22, 2020
@CecileRobertMichon
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 22, 2020
@CecileRobertMichon
Copy link
Contributor

/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 22, 2020
@scottslowe
Copy link
Contributor Author

As this is something I'm actively testing right now, I'd like to take this issue.

/assign

@detiber
Copy link
Member

detiber commented Apr 23, 2020

/lifecycle active
/remove-help

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 23, 2020
@vincepri
Copy link
Member

/milestone v0.3.6

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.x, v0.3.6 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants