Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCP: Handle kube-proxy upgrades #2544

Closed
vincepri opened this issue Mar 5, 2020 · 4 comments · Fixed by #2559
Closed

KCP: Handle kube-proxy upgrades #2544

vincepri opened this issue Mar 5, 2020 · 4 comments · Fixed by #2559
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@vincepri
Copy link
Member

vincepri commented Mar 5, 2020

This issue is a follow-up to #2226.

  • add code to KCP controller to update the kube-proxy DaemonSet in the workload cluster to match KCP.spec.version
  • images must be pullable (public or private registry), as the DaemonSet applies to all nodes in the workload cluster, and the OS images from which they booted won't have version n (current version) and n+1 (new version) both preloaded
  • we may need code in KCP controller to wait to update the DaemonSet until all machines (control plane and workers) are at least the same minor version or even patch version (e.g. don't want a 1.18 control plane, 1.17 worker nodes, and bump all kube-proxy pods to 1.18)

/kind feature
/milestone v0.3.0
/priority critical-urgent
/area control-plane

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0 milestone Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/control-plane Issues or PRs related to control-plane lifecycle management labels Mar 5, 2020
@vincepri
Copy link
Member Author

vincepri commented Mar 5, 2020

cc @detiber @sedefsavas

@randomvariable
Copy link
Member

randomvariable commented Mar 5, 2020

kubeadm would typically bump the kube-proxy daemonset during the control plane upgrade, so maybe in the first instance don't need to do the final bullet point?

at some point, would also need to account for clusters not running kube-proxy where that feature is implemented in the CNI. Calico is about to head in this direction (has experimental support for replacing kube-proxy with itself today)

@detiber
Copy link
Member

detiber commented Mar 5, 2020

at some point, would also need to account for clusters not running kube-proxy where that feature is implemented in the CNI. Calico is about to head in this direction (has experimental support for replacing kube-proxy with itself today)/

It should be pretty easy to skip the logic if the kube-proxy daemonset doesn't exist.

@sedefsavas
Copy link

/assign

/lifecycle active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants