Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e framework] Extract assertions from set up #2251

Closed
chuckha opened this issue Feb 3, 2020 · 2 comments · Fixed by #2294
Closed

[e2e framework] Extract assertions from set up #2251

chuckha opened this issue Feb 3, 2020 · 2 comments · Fixed by #2294
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@chuckha
Copy link
Contributor

chuckha commented Feb 3, 2020

User Story
Setting up a cluster is great, but we don't need to conflate all of the assertions with the actions of setting up.

Detailed Description
For example, a cluster should always come up. After that we want to make assertions about the cluster, but depending on the features the infrastructure provider supports they may or may not want to make certain assertions. One concrete example is FailureDomains. I'd like a way to assert that failure domains is working with my infrastructure provider, but since it's an optional feature, other infrastructure providers may not want to use those assertions.

/kind feature
/milestone Next
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 3, 2020
@chuckha
Copy link
Contributor Author

chuckha commented Feb 8, 2020

/assign
/active

@chuckha
Copy link
Contributor Author

chuckha commented Feb 8, 2020

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants