Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes needed for infrastructure provider implementer guide #1831

Closed
detiber opened this issue Dec 4, 2019 · 1 comment · Fixed by #1839
Closed

Fixes needed for infrastructure provider implementer guide #1831

detiber opened this issue Dec 4, 2019 · 1 comment · Fixed by #1839
Assignees
@ncdc
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone
v0.3.0

Comments

@detiber
Copy link
Member

detiber commented Dec 4, 2019

#1682 introduced new provider documentation. There are a few issues that need to be addressed in the current state of the docs:

  • docs/book/src/providers/implementers-guide/building_running_and_testing.md
    • Deployment -> Cluster API
      • Link for cloning the cluster-api repo is broken
  • docs/book/src/providers/implementers-guide/create_api.md
    • MailgunClusterSpec definition
      • Requester field is missing json tags and is not indented the same as previous lines.
  • docs/book/src/providers/implementers-guide/generate_crds.md
    • Under Create a Repository
      • link for go modules is broken

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2019
@prankul88 prankul88 mentioned this issue Dec 5, 2019
Merged
@ncdc ncdc added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Dec 5, 2019
@ncdc ncdc added this to the v0.3.0 milestone Dec 5, 2019
@ncdc
Copy link
Contributor

ncdc commented Dec 5, 2019

@prankul88 has a PR open for this but he's not in the org yet, so we can't assign it to him. Assigning to myself to indicate that it's assigned.

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncdc ncdc

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

📖 Fixes in infrastructure provider implementor guide prankul88/cluster-api
3 participants
@ncdc @detiber @k8s-ci-robot