/help
/triage accepted

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

+1, especially if we follow the same approach suggested for k/k that will ensure a transition period for everyone using the CAPI E2E test framework

/kind feature
/priority backlog

id be interested in picking this up, seems like a great improvement

@fabriziopandini on this point:

+1, especially if we follow the same approach suggested for k/k that will ensure a transition period for everyone using the CAPI E2E test framework

it looks like there are some caveats around importing the framework functions used in the example PR from the google convo (kubernetes/kubernetes#121394): https://pkg.go.dev/k8s.io/kubernetes/test/e2e/framework#section-readme

are we willing to accept these terms and import/use anyway?

Usage of the framework outside of Kubernetes is possible, but not encouraged. Downstream users have to be prepared to deal with API changes.

Do we need code from k/k to implement ginkgo labels? I was hoping we only need functionality from ginkgo and can ~ reuse our existing "labels" (the parts with "[]" in our test names)

not necessarily -- that was the alternative approach i was thinking is "just" using the Ginkgo functionality.

seems they have implemented some nice abstractions around it in k/k though (this valid features thing for example: https://github.com/pohly/kubernetes/blob/338fe7ad55cad858284d4c96df86d3cee9c7d29c/test/e2e/feature/feature.go#L136 or this WithLabel wrapper: https://github.com/pohly/kubernetes/blob/338fe7ad55cad858284d4c96df86d3cee9c7d29c/test/e2e/framework/ginkgowrapper.go#L513-L518)

Yeah. I'm just wondering if we need this sort of framework considering we only have very few labels :)

(and I'm not sure if our tests can or should be categorized by feature this way)

sure thing, ill draft a straightforward implementation

/assign