Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider implementation guide to Kubebuilder 2.0 #1090

Closed
pablochacin opened this issue Jun 30, 2019 · 5 comments · Fixed by #1682
Closed

Update provider implementation guide to Kubebuilder 2.0 #1090

pablochacin opened this issue Jun 30, 2019 · 5 comments · Fixed by #1682
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@pablochacin
Copy link
Contributor

pablochacin commented Jun 30, 2019

/kind bug

What steps did you take and what happened:

Following the instructions in the provider implementation documentation when building the project, the following errors/inconsistencies occurs:

Makefile patch

Instructions for building the project include a patch for the Makefile which includes this change:

 manifests:
 	go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go all
+	sed -i'' -e 's@^- manager_auth_proxy_patch.yaml.*@#&@' config/default/kustomization.yaml
+	kustomize build config/default/ > provider-components.yaml
+	echo "---" >> provider-components.yaml
+	kustomize build vendor/sigs.k8s.io/cluster-api/config/default/ >> provider-components.yaml

However, the actual Makefile looks as follows:

manifests: controller-gen
        $(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases

API package locatiion
Building the project fails due to a missing reference to apis package:

make 
/home/pchacin/workspace/go/bin/controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./api/...
go fmt ./...
build sigs.k8s.io/cluster-api-provider-solas/cmd/manager: cannot load sigs.k8s.io/cluster-api-provider-solas/pkg/apis: cannot find module providing package sigs.k8s.io/cluster-api-provider-solas/pkg/apis
make: *** [Makefile:46: fmt] Error 1

The problem is because the api is created under sigs.k8s.io/cluster-api-provider-solas/api/v1alpha1

This issue is related to #1075

Note

Environment:

Cluster-api version: 0.1.4

  • Minikube/KIND version: n/a
  • Kubernetes version: (use kubectl version): 1.4.1
  • OS (e.g. from /etc/os-release): openSUSE Leap 15.0
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2019
@detiber
Copy link
Member

detiber commented Jul 1, 2019

/assign @vincepri

@timothysc timothysc added this to the v1alpha2 milestone Jul 3, 2019
@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 3, 2019
@vincepri vincepri changed the title Fix provider implementation guide to kubebuilder 2.0 Update provider implementation guide to Kubebuilder 2.0 Aug 12, 2019
@vincepri
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 12, 2019
@vincepri vincepri removed the kind/bug Categorizes issue or PR as related to a bug. label Aug 12, 2019
@timothysc timothysc modified the milestones: v0.2.x, v0.3.0 Sep 26, 2019
@randomvariable
Copy link
Member

Related to providing an implementer guide as well #778

/assign

@liztio
Copy link
Contributor

liztio commented Oct 28, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 28, 2019
@randomvariable
Copy link
Member

CC @thebsdbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants