From 9862d9f10d63bb4c41c85d349456dd189365f67c Mon Sep 17 00:00:00 2001 From: killianmuldoon Date: Mon, 3 Jul 2023 19:00:47 +0100 Subject: [PATCH] Add comment about MachinePool MinReadySeconds behaviour Signed-off-by: killianmuldoon --- config/crd/bases/cluster.x-k8s.io_machinepools.yaml | 7 ++++--- exp/api/v1beta1/machinepool_types.go | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/config/crd/bases/cluster.x-k8s.io_machinepools.yaml b/config/crd/bases/cluster.x-k8s.io_machinepools.yaml index 2570928012ae..583c78507fa7 100644 --- a/config/crd/bases/cluster.x-k8s.io_machinepools.yaml +++ b/config/crd/bases/cluster.x-k8s.io_machinepools.yaml @@ -1034,9 +1034,10 @@ spec: type: string type: array minReadySeconds: - description: Minimum number of seconds for which a newly created machine - instances should be ready. Defaults to 0 (machine instance will - be considered available as soon as it is ready) + description: 'Minimum number of seconds for which a newly created + machine instances should be ready. Defaults to 0 (machine instance + will be considered available as soon as it is ready) NOTE: No logic + is implemented for this field and it currently has no behaviour.' format: int32 type: integer providerIDList: diff --git a/exp/api/v1beta1/machinepool_types.go b/exp/api/v1beta1/machinepool_types.go index fabf642d94c6..3d08de8260be 100644 --- a/exp/api/v1beta1/machinepool_types.go +++ b/exp/api/v1beta1/machinepool_types.go @@ -49,6 +49,7 @@ type MachinePoolSpec struct { // be ready. // Defaults to 0 (machine instance will be considered available as soon as it // is ready) + // NOTE: No logic is implemented for this field and it currently has no behaviour. // +optional MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`