From 4a2a287ed16c6e10540a7f915a85d0fb69f0e903 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Thu, 11 Mar 2021 11:59:03 -0600 Subject: [PATCH] Not klog v2 change in v1alpha4 provider docs This updates the v1alpha3-to-v1alpha4 docs to call out the move to klogv2 and recommending that all cluster providers do the same. Signed-off-by: Sean McGinnis --- .../src/developer/providers/v1alpha3-to-v1alpha4.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md b/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md index 9e234fe5949a..16c1e233024f 100644 --- a/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md +++ b/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md @@ -16,6 +16,16 @@ - Find and replace the `kube-rbac-proxy` version (usually the image is `gcr.io/kubebuilder/kube-rbac-proxy`) and update it to `v0.8.0`. +## Klog version + +- The klog package used has been upgraded to v2.5.x. It is recommended that + all providers also switch to using v2. + + - Change `import k8s.io/klog` to `import k8s.io/klog/v2` + - Change `import k8s.io/klog/klogr` to `import k8s.io/klog/v2/klogr` + - Update `go.mod` to `k8s.io/klog/v2 v2.5.0` + - Run `go mod tidy` to ensure all dependencies are updated. + ## The controllers.DeleteNodeAnnotation constant has been removed - This annotation `cluster.k8s.io/delete-machine` was originally deprecated a while ago when we moved our types under the `x-k8s.io` domain.