Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure via make verify that generate cluster-templates are always up-to-date #2153

Closed
sbueringer opened this issue Aug 3, 2023 · 1 comment · Fixed by #2172
Closed

Ensure via make verify that generate cluster-templates are always up-to-date #2153

sbueringer opened this issue Aug 3, 2023 · 1 comment · Fixed by #2172

Comments

@sbueringer
Copy link
Member

I think we should ensure via make verify on every PR that the generated cluster-templates in ./templates are up-to-date

Should ~ be:

  • create a target to run generate-flavors with templates as FLAVOR_DIR
  • add a corresponding verify target
  • Add the target to ALL_VERIFY_CHECKS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant