🐛 Image controller: don't attempt upload when adopting #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an image is to be adopted, the controller would still attempt to upload content when it observed the image in the queued state after having been created externally. This didn't result in incorrect behaviour because API validation ensures that images for adoption don't specify a source. This meant that no upload could be attempted, but it did result in a spurious error message reported both to the user and in the logs.
k8s-ci-robot
added
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/approve @mdbooth good to go I think, thanks for the fix |
k8s-ci-robot
added
lgtm
|
Confirmed from inspecting the logs that this clears up the untidy log messages. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an image is to be adopted, the controller would still attempt to upload content when it observed the image in the queued state after having been created externally. This didn't result in incorrect behaviour because API validation ensures that images for adoption don't specify a source. This meant that no upload could be attempted, but it did result in a spurious error message reported both to the user and in the logs.
/hold