⚠️ Convert APIServerPort to uint16 #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdbooth
force-pushed
the
apiserverport
branch
2 times, most recently
from
ed9e26f
to
b17b8fc
Compare
|
I decided to remove that commit from this PR anyway as I no longer need it for testing. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
This is a TCP port, which is an unsigned 16 bit integer. We were previously allowing it to be any integer. This is a breaking change, but as any working configuration would have to have a value which passes the new validation it should not break any working configuration.
mdbooth
force-pushed
the
apiserverport
branch
from
b17b8fc
to
033532e
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem was highlighted by the updated gosec linter brought in by #2173, which pointed out the unsafe conversion from int to int32. CAPI's control plane endpoint port is an int32. We were using int, which can be larger. We also weren't validating it.
APIServerPort is a TCP port, which is an unsigned 16 bit integer. We were
previously allowing it to be any integer.
This is a breaking change, but as any working configuration would have
to have a value which passes the new validation it should not break any
working configuration.