🌱 IdentityRefProvider: DRY obtaining OpenStackIdentityRef #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we add more resource controllers the pattern of adding another NewClientScopeFromFoo to ScopeFactory is becoming more cumbersome. This allows them all to use a common interface.
k8s-ci-robot
added
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdbooth
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we add more resource controllers the pattern of adding another
NewClientScopeFromFoo to ScopeFactory is becoming more cumbersome. This
allows them all to use a common interface.
Summary of changes
infrav1.IdentityRefProviderNewClientScopeFrom*inscope.Factorywith a singleNewClientScopeScopeFromObjectwhich takes a list of IdentityRefProviderThe reason it takes a list rather than a single object is so OpenStackMachine can continue to implement a fallback where it will use the IdentityRef from OpenStackCluster if it is not defined on the OpenStackMachine.
/hold