Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛issue-1711: Dependency on deprecated github.com/golang/mock #2048

Merged
merged 1 commit into from
May 3, 2024
Merged

🐛issue-1711: Dependency on deprecated github.com/golang/mock #2048

merged 1 commit into from
May 3, 2024

Conversation

MykolaRodin
Copy link
Contributor

@MykolaRodin MykolaRodin commented May 1, 2024

What this PR does / why we need it:

This MR uses uber-go/mock instead of deprecated github.com/golang/mock/gomock

Fixes: #1711

Copy link

linux-foundation-easycla bot commented May 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MykolaRodin / name: Mykola Rodin (21fa8b2)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @MykolaRodin!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @MykolaRodin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2024
Copy link

netlify bot commented May 1, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 21fa8b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6634b6bb79dd51000976e6a4
😎 Deploy Preview https://deploy-preview-2048--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 1, 2024
@mdbooth
Copy link
Contributor

mdbooth commented May 1, 2024

/ok-to-test

Thank you! I'll update the description with a Fixes stanza so #1711 is automatically closed when this merges.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2024
@mdbooth
Copy link
Contributor

mdbooth commented May 2, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
go.mod Outdated Show resolved Hide resolved
@MykolaRodin MykolaRodin requested a review from lentzi90 May 3, 2024 08:10
@lentzi90
Copy link
Contributor

lentzi90 commented May 3, 2024

Thanks! May I also ask that you squash the commits to one, please!

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@MykolaRodin
Copy link
Contributor Author

I tried to do it using git rebase -i with subsequent steps and failed. That is why I deleted my last commit (git reset --hard 1c5dc315bb125f92f43778bf1a75b6ad05f72739 and git push --force), made the required modifications in the code and committed them modifying the only remaining commit (git commit --amend and git push --force). That is the best I can do.

@lentzi90
Copy link
Contributor

lentzi90 commented May 3, 2024

It looks fine 🙂

@MykolaRodin
Copy link
Contributor Author

Thank you. If it is fine, could you please resolve our conversation above?

@lentzi90
Copy link
Contributor

lentzi90 commented May 3, 2024

I have already done so. This will merge as soon as all the tests have passed. The e2e test takes about 1 h so I estimate that this will be merge in about half an hour. 🙂

@k8s-ci-robot k8s-ci-robot merged commit 78e4bdb into kubernetes-sigs:main May 3, 2024
9 checks passed
@MykolaRodin MykolaRodin deleted the m.rodin/issue-1711 branch May 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Dependency on deprecated github.com/golang/mock
4 participants