-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛issue-1711: Dependency on deprecated github.com/golang/mock #2048
🐛issue-1711: Dependency on deprecated github.com/golang/mock #2048
Conversation
|
Welcome @MykolaRodin! |
Hi @MykolaRodin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test Thank you! I'll update the description with a |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! May I also ask that you squash the commits to one, please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
I tried to do it using |
It looks fine 🙂 |
Thank you. If it is fine, could you please resolve our conversation above? |
I have already done so. This will merge as soon as all the tests have passed. The e2e test takes about 1 h so I estimate that this will be merge in about half an hour. 🙂 |
What this PR does / why we need it:
This MR uses
uber-go/mock
instead of deprecatedgithub.com/golang/mock/gomock
Fixes: #1711