Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mix of trunk/untrunked ports. #929

Closed
adduarte opened this issue Jul 9, 2021 · 3 comments
Closed

Allow mix of trunk/untrunked ports. #929

adduarte opened this issue Jul 9, 2021 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@adduarte
Copy link

adduarte commented Jul 9, 2021

/kind feature

Describe the solution you'd like
Currently you can specify ports to be attached to the instance through
openStackMachine.Spec.Ports , and/or openStackMachine.Spec.Networks

And then ALL ports are either Trunked or Not Trunked depending on config.Trunk depending on instance.Trunk

Some NFV use cases use the vnic_type= direct to connet the VFs of an SR-IOV capable NIC to the node VM as additional untrunked ports using openStackMachine.Spec.Ports whilst attaching the node VM to the primary network via a virtio port using openStackMachine.Spec.Networks

As an OpenShift user I would like to be able to deploy a node VM attached to the primary network through a Trunked port with additional ports attached to the vm which are NOT trunked.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 9, 2021
@Xenwar
Copy link

Xenwar commented Jul 13, 2021

@adduarte
Do you see the PR #934 addressing the requirements ?
If not, I can create a separate issue for it.
Thanks.

@adduarte
Copy link
Author

@Xenwar #934 looks good to me. Thanks.

@mdbooth
Copy link
Contributor

mdbooth commented Oct 7, 2021

@adduarte Since #934 merged I think this is resolved. If you're happy please could you close this issue?

@adduarte adduarte closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants