Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityRef is not preserved converting between v1alpha4 and v1beta1 #1065

Closed
mdbooth opened this issue Nov 26, 2021 · 2 comments · Fixed by #1066
Closed

IdentityRef is not preserved converting between v1alpha4 and v1beta1 #1065

mdbooth opened this issue Nov 26, 2021 · 2 comments · Fixed by #1066
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Nov 26, 2021

/kind bug

Discovered by unit testing. IdentityRef annotated with +k8s:conversion-gen=false, possibly because it was new in v1alpha4 and we wanted to ignore it when converting from v1alpha3. However, we don't want to ignore it when converting to v1beta1, but it is still ignored.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 26, 2021
@mdbooth mdbooth mentioned this issue Nov 26, 2021
Merged
@hidekazuna
Copy link
Contributor

/cc @tobiasgiese

@tobiasgiese
Copy link
Member

I added the annotation in #937 because of the conversion from v1alpha3 to v1alpha4, that's true.
But indeed we don't want to ignore the conversion to v1beta1 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
4 participants
@mdbooth @hidekazuna @k8s-ci-robot @tobiasgiese