Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Webhooks for IBMPowerVSClusterTemplate #975

Closed
Karthik-K-N opened this issue Nov 25, 2022 · 3 comments · Fixed by #1174
Closed

Add Webhooks for IBMPowerVSClusterTemplate #975

Karthik-K-N opened this issue Nov 25, 2022 · 3 comments · Fixed by #1174
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Next

Comments

@Karthik-K-N
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
IBMPowerVSClusteTempalate was added as a part of PR: #967, We need to add webhooks and webhooks tests for same

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Nov 25, 2022
@mkumatag mkumatag added this to the Next milestone Jan 13, 2023
@mkumatag mkumatag added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 27, 2023
@Sajiyah-Salat
Copy link

hello @mkumatag @Karthik-K-N can you please describe this issue in detail. I would love to work on this issue. Thank you.

@Karthik-K-N
Copy link
Contributor Author

Hi @Sajiyah-Salat, Thank you for showing interest in contributing and it would be a very good issue to get started.

cluster-api has a concept called cluster-class using which user can create multiple clusters from a template, More details about it can be found here: https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-class/index.html

This repository (cluster-api-provider-ibmcloud) supports provisioning of k8s cluster either in IBM Cloud Power VS infrastructure or IBM Cloud VPC infrastructure.

We have already added support for using cluster class for IBM Cloud Power VS infrastructure via PR:#967, this can be used as reference.

In this issue we wanted to add cluster class support for VPC infrastructure.

Please let me know if you have any queries or need any help to get started.

@Sajiyah-Salat
Copy link

I got the issue.
I have gone through the referenced pr.
Their 10+ files have changed.
I wonder how this is good first issue.

@KeerthanaAP KeerthanaAP mentioned this issue Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Add Webhooks for IBMPowerVSClusterTemplate KeerthanaAP/cluster-api-provider-ibmcloud
4 participants
@mkumatag @k8s-ci-robot @Karthik-K-N @Sajiyah-Salat