Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the events #637

Closed
mkumatag opened this issue Apr 19, 2022 · 2 comments · Fixed by #639
Closed

Refine the events #637

mkumatag opened this issue Apr 19, 2022 · 2 comments · Fixed by #639
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@mkumatag
Copy link
Member

/kind cleanup
/area provider/ibmcloud

What steps did you take and what happened:
This issue is to list down some of the recent enhancement/change required for the events for the projects

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Apr 19, 2022
@mkumatag mkumatag added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 19, 2022
@mkumatag
Copy link
Member Author

/assign @Prajyot-Parab

@mkumatag mkumatag changed the title Refines the events Refine the events Apr 19, 2022
@mkumatag
Copy link
Member Author

Event for the IBMPowerVSImage resource:

Events:
  Type    Reason                  Age                  From                 Message
  ----    ------                  ----                 ----                 -------
  Normal  SuccessfulRetriveImage  2m49s (x6 over 39m)  ibmcloud-controller  Retrieved Image "ibm-powervs-1-image"

seen the above repeated event which is part of reconcile loop which keep executing every time, and k8s keeps track of how many times this record is created which is 6 times(x6) in this case which looks to be little odd because in most of the cases in k8s world this means that any given resource tried operation so many times(used especially when someone tried doing something in case of failure). IMO it will be good to not record this event and anyway this state is already checked and marked as Ready to false if this condition doesn't satisfy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants