Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the missing functions in powervs service into mock #563

Closed
mkumatag opened this issue Feb 16, 2022 · 0 comments · Fixed by #564
Closed

Add all the missing functions in powervs service into mock #563

mkumatag opened this issue Feb 16, 2022 · 0 comments · Fixed by #564
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@mkumatag
Copy link
Member

/kind bug
/area provider/ibmcloud

What steps did you take and what happened:

Fix following things:

  • Not all the functions are mocked in here, hence need to add all the missing methods into the interface
  • No need to expose the powervs service clients directly, this may cause user to use those clients directly and hard to use mocking in the controller, hence converting the clients to private.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Feb 16, 2022
@mkumatag mkumatag self-assigned this Feb 16, 2022
@mkumatag mkumatag added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/bug Categorizes issue or PR as related to a bug. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Feb 16, 2022
@mkumatag mkumatag added this to the 0.2 milestone Feb 16, 2022
@mkumatag mkumatag added area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug. labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants