Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose additional addresses to the machine spec #561

Closed
mkumatag opened this issue Feb 16, 2022 · 1 comment · Fixed by #562
Closed

Expose additional addresses to the machine spec #561

mkumatag opened this issue Feb 16, 2022 · 1 comment · Fixed by #562
Assignees
@mkumatag
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
0.2.0

Comments

@mkumatag
Copy link
Member

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
We have this flow to set the addresses only for the IP address, need to enhance this flow to add hostname and internalDNS as well

cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.go

Line 363 in 1573880

func (m *PowerVSMachineScope) SetAddresses(networks []*models.PVMInstanceNetwork) {

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Feb 16, 2022
@mkumatag
Copy link
Member Author

/assign

@mkumatag mkumatag added this to the 0.2 milestone Feb 16, 2022
@mkumatag mkumatag added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 16, 2022
@mkumatag mkumatag mentioned this issue Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkumatag mkumatag

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Adding more addresses to the machine spec mkumatag/cluster-api-provider-ibmcloud
2 participants
@mkumatag @k8s-ci-robot