Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason to keep VPC and ResourceGroup param in VPC Security Group #1770

Closed
dharaneeshvrd opened this issue May 13, 2024 · 3 comments · Fixed by #1783
Closed

Reason to keep VPC and ResourceGroup param in VPC Security Group #1770

dharaneeshvrd opened this issue May 13, 2024 · 3 comments · Fixed by #1783
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@dharaneeshvrd
Copy link
Contributor

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
This issue is to continue the discussion on the question asked here

@cjschaef I just have a comment on VPC and ResourceGroup properties of type SecurityGroup. are you planning to pass a different VPC and Resource Group than the one cluster is using? Just wanted to understand what is the intention for the properties?

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels May 13, 2024
@dharaneeshvrd
Copy link
Contributor Author

@cjschaef Please revert back when you get a chance!

@dharaneeshvrd
Copy link
Contributor Author

Raised this PR #1783 to remove the VPC and SecurityGroup field for now to make it simple and if need we can add it back.

@cjschaef
Copy link
Contributor

cjschaef commented Jul 2, 2024

The specifications for having a ResourceGroup and VPC defined in the SecurityGroup resource allowed for BYON support to be easier and cleaner.

I will have to re-review and refactor all related VPC functional work to account for the renamed resources and attempt to refactor functionality of SecurityGroup and SGRule creation while keeping the ability of BYON support in mind.

I cannot re-open this issue, so I will open an issue as needed if I indeed have to revert the changes that have been made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants