Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and add InternalILB as a CAPZ feature flag #5304

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Create and add InternalILB as a CAPZ feature flag #5304

merged 1 commit into from
Nov 25, 2024

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Nov 22, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • This PR will add a feature flag enabling internal ILB for MSFT tenants.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5296

Special notes for your reviewer:

TODOs:

  • cherry-pick candidate
  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

^ Will add a proper release note once the Internal ILB solution is minimally working.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 22, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
jackfrancis
jackfrancis reviewed Nov 22, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 22, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.53%. Comparing base (78e1385) to head (e25ff06).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5304   +/-   ##
=======================================
  Coverage   52.53%   52.53%           
=======================================
  Files         272      272           
  Lines       29372    29372           
=======================================
  Hits        15432    15432           
  Misses      13143    13143           
  Partials      797      797

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch 2 times, most recently from 912a1e2 to 75cb634 Compare November 22, 2024 21:56
@nawazkh nawazkh marked this pull request as ready for review November 22, 2024 21:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Jont828 November 22, 2024 21:57
willie-yao
willie-yao reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: Is this PR only adding the feature flag, and the actual functionality of the flag added in a later PR?

Makefile Outdated Show resolved Hide resolved
docs/book/src/developers/development.md Outdated Show resolved Hide resolved
docs/book/src/developers/development.md Outdated Show resolved Hide resolved
@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch 3 times, most recently from fdd4292 to c5bfdd2 Compare November 22, 2024 22:21
@nawazkh
Copy link
Member Author

nawazkh commented Nov 22, 2024

Just wondering: Is this PR only adding the feature flag, and the actual functionality of the flag added in a later PR?

You are right. This PR is merely adding the feature flag and the functionality will be rolled out in subsequent PRs.
We reverted a bunch of PRs that added internal LB functionality, so will be reopening/recycling them one by one instead of clubbing all into one PR.

jackfrancis
jackfrancis reviewed Nov 22, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@willie-yao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d022c24870cad7d6d9dd57c9bcff204ebbaba59

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@nawazkh nawazkh requested a review from jackfrancis November 22, 2024 23:25
@nawazkh nawazkh requested a review from jackfrancis November 22, 2024 23:35
@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch 2 times, most recently from 9f8ee8c to 41d2847 Compare November 22, 2024 23:47
jackfrancis
jackfrancis reviewed Nov 22, 2024
View reviewed changes
Makefile Outdated
@@ -746,7 +747,7 @@ kind-create: $(KUBECTL) ## Create capz kind cluster if needed.
aks-create: $(KUBECTL) ## Create aks cluster as mgmt cluster.
./scripts/aks-as-mgmt.sh

.PHONY: tilt-up
.PHONY: tilt-up ## TODO: EXP_APISERVER_ILB should be set to "true" either at the template level or via the env as being done here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just go ahead and add this new config to L755 below

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added via 8fe5817

@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch from 8fe5817 to 4b1901d Compare November 23, 2024 00:20
@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch from 4b1901d to e25ff06 Compare November 23, 2024 03:31
@nawazkh
Copy link
Member Author

nawazkh commented Nov 25, 2024

/test pull-cluster-api-provider-azure-e2e

@nawazkh
Create and add InternalILB as a CAPZ feature flag
f7d70c4 
- update development.md
- update manager patch policy with the feature flags.
@nawazkh nawazkh force-pushed the feature_flag_internal_ilb branch from e25ff06 to f7d70c4 Compare November 25, 2024 17:44
@nawazkh nawazkh mentioned this pull request Nov 25, 2024
Merged
4 tasks
@nawazkh nawazkh requested a review from jackfrancis November 25, 2024 18:36
willie-yao
willie-yao approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a89aaeec7ac6664d63160696ac7bfe8b55f934d9

jackfrancis
jackfrancis approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6abf1c3 into kubernetes-sigs:main Nov 25, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 25, 2024
@nawazkh nawazkh deleted the feature_flag_internal_ilb branch November 26, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@marosset marosset Awaiting requested review from marosset

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@jackfrancis jackfrancis

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@nawazkh @k8s-ci-robot @willie-yao @jackfrancis