Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network describer interface #824

Closed
alexeldeib opened this issue Jul 23, 2020 · 1 comment · Fixed by #984
Closed

add network describer interface #824

alexeldeib opened this issue Jul 23, 2020 · 1 comment · Fixed by #984
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@alexeldeib
Copy link
Contributor

/kind cleanup

Describe the solution you'd like
This is a convenient way to allow for multiple infrastructure types to implement the necessary interfaces (ClusterDescriber and NetworkDescriber) to describe all required Azure infrastructure and secrets.

It's a stepping stone to removing AzureCluster from MachineScope, so MachineScope can use different Cluster/ControlPlane providers

Anything else you would like to add:
#822 (comment)

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 23, 2020
@CecileRobertMichon
Copy link
Contributor

/assign @alexeldeib
/assign

Just assigning us for now so no one else starts working on it while we figure out how to minimize merge conflicts. If you don't open a PR for it, I can after I finish with VMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants