Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Kubeadm when enabling MachinePools #4854

Closed
salasberryfin opened this issue May 15, 2024 · 0 comments · Fixed by #4931
Closed

Remove dependency on Kubeadm when enabling MachinePools #4854

salasberryfin opened this issue May 15, 2024 · 0 comments · Fixed by #4931
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@salasberryfin
Copy link
Contributor

/kind bug

What steps did you take and what happened:
When installing CAPZ with the MachinePools experimental feature enabled, the controller is configured to watch Kubeadm config objects, which effectively prevents users from using any other bootstrap provider other than Kubeadm.

Watches(
&kubeadmv1.KubeadmConfig{},
handler.EnqueueRequestsFromMapFunc(KubeadmConfigToInfrastructureMapFunc(ctx, ampr.Client, log)),
builder.WithPredicates(predicate.ResourceVersionChangedPredicate{}),
).

What did you expect to happen:
As a user I would like to be able to use CAPZ + MachinePools with the bootstrap provider of my choice. Other providers that implement support for MachinePools do not include dependencies on Kubeadm (see CAPA).

Anything else you would like to add:
I'd like to submit a PR that removes this watcher if this is considered an accepted proposal.

Environment:

  • cluster-api-provider-azure version: v1.15.0
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 15, 2024
@salasberryfin salasberryfin changed the title Removing dependency on Kubeadm when enabling MachinePools Remove dependency on Kubeadm when enabling MachinePools May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Archived in project
2 participants