-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constants for CAPZ Kind names #4223
Comments
/good-first-issue |
@CecileRobertMichon: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @CecileRobertMichon Can I work on this issue? |
@SD-13 yes please assign yourself to the issue by commenting "/assign" |
/assign |
Hey @CecileRobertMichon I am not sure what would be the correct location to add the constants. Should we add them in |
/kind cleanup
What needs cleanup:
[A clear and concise description of what needs to be cleaned up.]
There are a bunch of hardcoded strings in the codebase for the CRD Kinds (
"AzureCluster"
,"AzureCluster"
,"AzureMachinePool"
,"AzureManagedCluster"
,"AzureManagedControlPlane"
,"AzureClusterIdentity"
, etc.). We should add constants for these strings and reuse them throughout the codebase instead of hardcoding them in several places.Describe the solution you'd like
[Description of how you would like the cleanup to be done.]
Files to change: 2
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
The text was updated successfully, but these errors were encountered: