Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for CAPZ Kind names #4223

Closed
2 tasks
CecileRobertMichon opened this issue Nov 2, 2023 · 6 comments · Fixed by #4254
Closed
2 tasks

Add constants for CAPZ Kind names #4223

CecileRobertMichon opened this issue Nov 2, 2023 · 6 comments · Fixed by #4254
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@CecileRobertMichon
Copy link
Contributor

/kind cleanup

What needs cleanup:
[A clear and concise description of what needs to be cleaned up.]

There are a bunch of hardcoded strings in the codebase for the CRD Kinds ("AzureCluster", "AzureCluster", "AzureMachinePool", "AzureManagedCluster", "AzureManagedControlPlane", "AzureClusterIdentity", etc.). We should add constants for these strings and reuse them throughout the codebase instead of hardcoding them in several places.

Describe the solution you'd like
[Description of how you would like the cleanup to be done.]

Files to change: 2

  • File 1
    • Specific lines to cleanup
  • File 2
    • Specific lines to cleanup

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 2, 2023
@CecileRobertMichon
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 2, 2023
@SD-13
Copy link
Contributor

SD-13 commented Nov 2, 2023

Hi @CecileRobertMichon Can I work on this issue?

@CecileRobertMichon
Copy link
Contributor Author

@SD-13 yes please assign yourself to the issue by commenting "/assign"

@SD-13
Copy link
Contributor

SD-13 commented Nov 2, 2023

/assign

@SD-13
Copy link
Contributor

SD-13 commented Nov 4, 2023

Hey @CecileRobertMichon I am not sure what would be the correct location to add the constants. Should we add them in api/v1beta1/consts.go?

@SD-13 SD-13 moved this to Needs Review in CAPZ Planning Nov 14, 2023
@SD-13 SD-13 moved this from Needs Review to In Progress in CAPZ Planning Nov 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in CAPZ Planning Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
Archived in project
3 participants