Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securityRules should support source address in plural #3377

Closed
bavarianbidi opened this issue Mar 30, 2023 · 3 comments · Fixed by #3961
Closed

securityRules should support source address in plural #3377

bavarianbidi opened this issue Mar 30, 2023 · 3 comments · Fixed by #3961
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bavarianbidi
Copy link
Contributor

/kind feature

Describe the solution you'd like

As a User i want to group multiple network sources into one securityRule. At the moment i have to specify for each source one securityRule.

Anything else you would like to add:

In theory it should be an easy one to extend the securityRule struct by a new field called Sources and do the conversion to SourceAddressPrefixes in here.

But maybe it's also worth the discussion to keep the existing Source field and convert it directly to SourceAddressPrefixes as at least in theory, on Azure side nothing will (should) change.

Environment:

  • cluster-api-provider-azure version: 1.9.0
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 30, 2023
@nawazkh
Copy link
Member

nawazkh commented May 23, 2023

/assign

@nawazkh
Copy link
Member

nawazkh commented Jun 20, 2023

This is still on my radar.

@nawazkh
Copy link
Member

nawazkh commented Aug 23, 2023

Started taking a look at this now, will update as I make progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants