Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: not considering all AZ, restrictions on VM SKU #222

Closed
alexeldeib opened this issue Jun 14, 2019 · 0 comments · Fixed by #223
Closed

bug: not considering all AZ, restrictions on VM SKU #222

alexeldeib opened this issue Jun 14, 2019 · 0 comments · Fixed by #223
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alexeldeib
Copy link
Contributor

/kind bug

What steps did you take and what happened:
compute.ResourceSkusClient returns the first page of a paginated results set.

There are two issues in the current implementation. Not all the pages are iterated. This results in users potentially erroring out on valid SKUs. There may also be restrictions either at the Location level for a given subscription, or at the Zone level.

If a machine SKU exists in a Location but is Location restricted, you may not deploy this SKU at all.

If a machine SKU exists in a Location but all its listed Zones are restricted (or there are none listed), you may deploy the SKU but only using Fault/Update domains.

What did you expect to happen:
Iterate the whole result result, and properly handle restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants