Support "managed" semantics for an existing private DNS zone

[dlipovetsky]

/kind feature

Describe the solution you'd like
I have to use an existing private DNS zone. I am not authorized to delete the zone, but only to manage vnet links and records in the zone. I want CAPZ to manage the vnet link and records in this zone. When CAPZ deletes the cluster, I want it to only delete the records and vnet link it created, and to not delete the zone itself.

Anything else you would like to add:
CAPZ sees a private DNS zone as either "managed" or "unmanaged." If the zone is "managed," then CAPZ

• manages a vnet link in the zone
• manages the records in the zone
• deletes the zone when it deletes the cluster

However, if I configure CAPZ to use an existing private DNS zone, then CAPZ will treat is as "unmanaged," by default. Afterward, I can add a tag to the private DNS zone, and CAPZ will treat it as "managed." However, CAPZ deletes a "managed" zone when it deletes the cluster.

Environment:

• cluster-api-provider-azure version: v1.1.0
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[CecileRobertMichon]

@dlipovetsky this seems to be a bug. We shouldn't return here when the private zone is unmanaged, just skip creating/updating the zone, since the management of vnet links is separate.

Also, that log message about tagging the zone manually is misleading, it should only apply to DNS zones that were created with previous versions of CAPZ, before tags were being applied.

[CecileRobertMichon]

/kind bug

[shysank]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[shysank]

/close
closing this as this addressed by #2007