Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom cloud provider secret is overwritten with default values #1902

Closed
devigned opened this issue Dec 2, 2021 · 1 comment · Fixed by #1906
Closed

custom cloud provider secret is overwritten with default values #1902

devigned opened this issue Dec 2, 2021 · 1 comment · Fixed by #1906
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@devigned
Copy link
Contributor

devigned commented Dec 2, 2021

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
Contents of the control plane custom cloud provider secret are overwritten with default values.

What did you expect to happen:
The secret should not be overwritten if it already exists and is not marked as owned by the cluster.

Anything else you would like to add:
@nilo19 ran into this and reported it to me. I have not verified the behavior.

/help
/good-first-issue

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 2, 2021
@CecileRobertMichon
Copy link
Contributor

/remove-good-first-issue

we should validate this issue exists before we mark it as suitable for new contributors

@k8s-ci-robot k8s-ci-robot removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
3 participants