Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async privatedns #1715

Closed
Tracked by #1702
CecileRobertMichon opened this issue Sep 21, 2021 · 5 comments · Fixed by #2007
Closed
Tracked by #1702

async privatedns #1715

CecileRobertMichon opened this issue Sep 21, 2021 · 5 comments · Fixed by #2007
Assignees
@shysank @sonasingh46
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v1.3

Comments

@CecileRobertMichon
Copy link
Contributor

No description provided.

@CecileRobertMichon CecileRobertMichon mentioned this issue Sep 21, 2021
Closed
23 tasks
@CecileRobertMichon CecileRobertMichon added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 21, 2021
@sonasingh46
Copy link
Contributor

/assign sonasingh46

@shysank
Copy link
Contributor

shysank commented Jan 11, 2022

/assign shysank

@Jont828
Copy link
Contributor

Jont828 commented Jan 24, 2022

Hey @shysank, how's it going on async private DNS? I've refactored a lot of the async PRs and also merged #1874 which changes the GET logic, so let me know if you have any questions!

@shysank shysank mentioned this issue Jan 26, 2022
Merged
3 tasks
@shysank
Copy link
Contributor

shysank commented Jan 26, 2022

hey @Jont828, thanks! I was distracted with other things, so couldn't get to this sooner. I've opened a pr to address this, ptal whenever you get a chance.

@Jont828
Copy link
Contributor

Jont828 commented Jan 31, 2022

Sounds good! Just left some comments.

@CecileRobertMichon CecileRobertMichon mentioned this issue Mar 9, 2022
Merged
3 tasks
@CecileRobertMichon CecileRobertMichon added this to the v1.3 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shysank shysank

@sonasingh46 sonasingh46

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Make private dns reconcile/delete async shysank/cluster-api-provider-azure
4 participants
@CecileRobertMichon @shysank @Jont828 @sonasingh46