Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests for machinepool clusters are not collecting logs #1352

Closed
jsturtevant opened this issue Apr 30, 2021 · 4 comments · Fixed by #1389
Closed

e2e tests for machinepool clusters are not collecting logs #1352

jsturtevant opened this issue Apr 30, 2021 · 4 comments · Fixed by #1389
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jsturtevant
Copy link
Contributor

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
If you look at logs for a cluster that was VMSS on a CI run you will not find the logs for the VMSS ndes:

https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/periodic-cluster-api-provider-azure-e2e-full/1387735706947817472/artifacts/clusters/capz-e2e-j51u3m/machines/

What did you expect to happen:
logs for the VMSS nodes to be collected.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

It looks like this is because the framework only looks for machines

Byf("Dumping workload cluster %s/%s logs", namespace, name)
acp.ClusterProxy.CollectWorkloadClusterLogs(ctx, namespace, name, outputPath)

https://github.com/kubernetes-sigs/cluster-api/blob/45b6080c276453c2f30fae3e093679a15c7ccdfd/test/framework/cluster_proxy.go#L218-L219

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 30, 2021
@jsturtevant
Copy link
Contributor Author

fyi @devigned

@devigned
Copy link
Contributor

devigned commented May 4, 2021

I think this is an addition for CAPI in the longer term. For the short term, we should probably do it ourselves.

@CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants