Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup from Logging as Dep PR #716

Closed
2 of 3 tasks
chuckha opened this issue Apr 12, 2019 · 7 comments · Fixed by #1108
Closed
2 of 3 tasks

Followup from Logging as Dep PR #716

chuckha opened this issue Apr 12, 2019 · 7 comments · Fixed by #1108
Assignees
@chuckha
Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
Next

Comments

@chuckha
Copy link
Contributor

chuckha commented Apr 12, 2019 •
edited
Loading

This is a checklist of the more minor things to figure out after the major refactor

/assign
/lifecycle active
/priority backlog
/milestone Next
@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the Next milestone Apr 12, 2019
@chuckha chuckha mentioned this issue Apr 12, 2019
Merged
@chuckha chuckha removed the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label May 9, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2019
@detiber
Copy link
Member

detiber commented Aug 7, 2019

@chuckha is this issue still valid?

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 6, 2019
@chuckha
Copy link
Contributor Author

chuckha commented Sep 6, 2019

/remove-lifecycle rotten

I'll look into these and see if they are still relevant.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 6, 2019
@vincepri
Copy link
Member

vincepri commented Sep 6, 2019

I think we solved this issue when we moved to Kubebuilder v2 and the new loggers

@chuckha chuckha mentioned this issue Sep 6, 2019
Merged
@chuckha
Copy link
Contributor Author

chuckha commented Sep 6, 2019

two were invalid one was still a valid unhandled/unlogged error, I opened a PR to fix the unhandled error.

@chuckha
Copy link
Contributor Author

chuckha commented Sep 6, 2019

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuckha chuckha

Labels
lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

🐛 handle an unhandled error chuckha/cluster-api-provider-aws
5 participants
@chuckha @detiber @vincepri @k8s-ci-robot @fejta-bot