Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all owned VPCEs during VPC deletion #5192

Closed
s3rj1k opened this issue Oct 28, 2024 · 1 comment · Fixed by #5193
Closed

Remove all owned VPCEs during VPC deletion #5192

s3rj1k opened this issue Oct 28, 2024 · 1 comment · Fixed by #5193
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@s3rj1k
Copy link
Contributor

s3rj1k commented Oct 28, 2024

/kind feature

Describe the solution you'd like
CAPA should remove all owned VPCEs that are bound to VPC, during VPC deletion.

In case of EKS ManagedControlPlane deletion, when owned VPC gets deleted this code is a no-op due to no s3 for ManagedControlPlane

Anything else you would like to add:
ref: October 28, 2024 Meeting Notes

Environment:

  • Cluster-api-provider-aws version: v2.6.1
  • Kubernetes version: (use kubectl version): v1.31.0
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@s3rj1k s3rj1k mentioned this issue Oct 28, 2024
Merged
5 tasks
@slysunkin slysunkin mentioned this issue Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat: Remove owned VPCEs when deleting VPC. s3rj1k/cluster-api-provider-aws
2 participants
@s3rj1k @k8s-ci-robot