Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow awsmachinepool to be set to 0 for minsize instead of 1 for v1alpha4 and v1alpha3 #4208

Closed
tasdikrahman opened this issue Apr 6, 2023 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@tasdikrahman
Copy link
Member

/kind feature

Would like the minsize to be 0 instead of the current 1 for both the above api's as the awsmachinepool can scale down to 0

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/release-1.5/exp/api/v1alpha4/awsmachinepool_types.go#L45
https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/release-1.5/exp/api/v1alpha3/awsmachinepool_types.go#L45

related to this #3242

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Update the min size to 0 for the above API's

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version: v1.5.5
  • Kubernetes version: (use kubectl version): 1.22
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tasdikrahman
Copy link
Member Author

closing this as discussed in slack here, both the above API's have been deprecated, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants