make manifests-dev sometimes fails

[chuckha]

/kind bug

I was really surprised to find inconsistent behavior here:

 salazar:cluster-api-provider-aws cha$ make manifests-dev
MANAGER_IMAGE=gcr.io/chuck-heptio/cluster-api-aws-controller:0.0.2 /Applications/Xcode.app/Contents/Developer/usr/bin/make manifests
./cmd/clusterctl/examples/aws/generate-yaml.sh
Done generating /Users/cha/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterctl/examples/aws/out/cluster.yaml
Done generating /Users/cha/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterctl/examples/aws/out/machines.yaml
Done generating /Users/cha/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterctl/examples/aws/out/aws_manager_image_patch.yaml
Done copying /Users/cha/go/src/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterctl/examples/aws/out/addons.yaml
clusterawsadm alpha bootstrap generate-aws-default-profile > cmd/clusterctl/examples/aws/out/credentials
no such flag -v
make[1]: *** [cmd/clusterctl/examples/aws/out/credentials] Error 1
make: *** [manifests-dev] Error 2
 salazar:cluster-api-provider-aws cha$ make manifests-dev
MANAGER_IMAGE=gcr.io/chuck-heptio/cluster-api-aws-controller:0.0.2 /Applications/Xcode.app/Contents/Developer/usr/bin/make manifests
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd
CRD files generated, files can be found under path /Users/cha/go/src/sigs.k8s.io/cluster-api-provider-aws/config/crds.
kustomize build config/default/ > cmd/clusterctl/examples/aws/out/provider-components.yaml
2018/11/16 14:01:44 Adding nameprefix to Namespace resource will be deprecated in next release.
echo "---" >> cmd/clusterctl/examples/aws/out/provider-components.yaml
kustomize build vendor/sigs.k8s.io/cluster-api/config/default/ >> cmd/clusterctl/examples/aws/out/provider-components.yaml
2018/11/16 14:01:44 Adding nameprefix to Namespace resource will be deprecated in next release.
 salazar:cluster-api-provider-aws cha$ make manifests-dev
MANAGER_IMAGE=gcr.io/chuck-heptio/cluster-api-aws-controller:0.0.2 /Applications/Xcode.app/Contents/Developer/usr/bin/make manifests
clusterawsadm alpha bootstrap generate-aws-default-profile > cmd/clusterctl/examples/aws/out/credentials
no such flag -v
make[1]: *** [cmd/clusterctl/examples/aws/out/credentials] Error 1
make: *** [manifests-dev] Error 2
 salazar:cluster-api-provider-aws cha$ 

This is three runs, it fails twice and succeeds once.

What steps did you take and what happened:
I ran make manifests-dev a few times in a row.

What did you expect to happen:
I expected the same thing each time.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[randomvariable]

That bit of workflow's going away in #371, so hopefully will be irrelevant.

[echarles]

The issue no such flag -v is covered in #341 (the block code removal in cmd/clusterawsadm/cmd/root.go, see also my comment on that PR).

[randomvariable]

/assign /lifecycle-active

[sethp-nr]

@echarles I don't see a comment from you on #341, did you have some more context to add around that change?

I'm happy to open a followup PR if you'd rather we fixed the no such flag -v thing differently.

[echarles]

@sethp-nr It was more a question on the diff page than a comment

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/341/files/00883aebc6af3937eb205271cde8bef2b88696fc#diff-2f3eed492c5a8e8eec09b95786ad5d63

Simply removing that code block in cmd/clusterawsadm/cmd/root.go solves the issue, but my question was "why was it working before?"